Incorrect Retry on connection error check

mollie / mollie-api-php

Mollie API client for PHP

http://www.mollie.com

BSD 2-Clause "Simplified" License

552 stars 191 forks source link

Incorrect Retry on connection error check #136

Closed NiekvandenBogaard closed 6 years ago

NiekvandenBogaard commented 6 years ago

https://github.com/mollie/mollie-api-php/blob/5e81dac60352723ec512edd0ce2b9edfb859b888/src/Mollie/API/Client.php#L406

$connectionErrors stores all connection error numbers as KEYS not as VALUES so 'in_array' function should be replaced by 'array_key_exists' function on the mentioned line.

Smitsel commented 6 years ago

Hi Niek,

Nice find! Fixed it in https://github.com/mollie/mollie-api-php/pull/137 Feel free to create a PR next time :)