search

mollie / mollie-api-php

Mollie API client for PHP
http://www.mollie.com
BSD 2-Clause "Simplified" License
552 stars 191 forks source link

Oauth / Connect token management methods and examples missing #238

Closed sandervanhooft closed 6 years ago

sandervanhooft commented 6 years ago

Specifications

Describe the issue

(I came across this issue while updating the official Mollie docs.)

Examples for Oauth / Connect token management are missing.

Only setAccessToken(...) is currently mentioned (here).

How to perform the initial and refresh requests is not described.

It seems to me that convenience methods are missing on the client class as well, so I'm not sure how to document this / what's the best approach here.

Perhaps the Laravel-Mollie implementation can serve as inspiration (link).

willemstuursma commented 6 years ago

OAuth should be handled using league/oauth for which we created a provider.

Does that help @sandervanhooft ?

sandervanhooft commented 6 years ago

I think that's the best way indeed.

Perhaps document this in the readme?

willemstuursma commented 6 years ago

Yes, that would be great. Could you open a PR?

sandervanhooft commented 6 years ago

Any suggestions for the official docs on this topic?

sandervanhooft commented 6 years ago

Closing here. Continue here.