search

mollie / mollie-api-php

Mollie API client for PHP
http://www.mollie.com
BSD 2-Clause "Simplified" License
552 stars 191 forks source link

Releases don't include the composer-loaded things #480

Closed Healyhatman closed 4 years ago

Healyhatman commented 4 years ago

The readme state that the files in the releases page include everything for those of us unable to use composer, but as of 3 releases ago they don't include everything. No vendor folder.

sandervanhooft commented 4 years ago

Confirmed.

@willemstuursma did anything change on the repo settings / build? (not at my end)

sandervanhooft commented 4 years ago

The issue lies with the Travis build. Will need to investigate further.

sandervanhooft commented 4 years ago

@willemstuursma The vendor-included build is failing on Travis due to bad GitHub credentials. See for example this build.

Can you check these credentials?

Noordkust-nikolai commented 4 years ago

Any updates on this?? :) I am still waiting for mollie's response now on this subject.. after a week.. with the missing autoloader being the main problem..

sandervanhooft commented 4 years ago

We're looking into this @Noordkust-nikolai . If you're looking for a quick fix, take a look at the makefile. You can try and run these commands to build the autoload directory locally:

https://github.com/mollie/mollie-api-php/blob/df60ebfc2463cdffc1faeb1fa9419911812ac6f8/Makefile#L6:L22

Noordkust-nikolai commented 4 years ago

@sandervanhooft ok ok! thanks! I'll take a look into that :)

willemstuursma commented 4 years ago

@willemstuursma The vendor-included build is failing on Travis due to bad GitHub credentials. See for example this build.

Can you check these credentials?

I've updated the credentials.

sandervanhooft commented 4 years ago

Just released v2.22.1 to fix this issue.

Thanks all!

Noordkust-nikolai commented 4 years ago

I'm getting this from the vendor, PHP version 5.6.40. [Thu Aug 20 12:49:33.198978 2020] [:error] [pid 15015] [client 85.241.130.64:50426] PHP Parse error: syntax error, unexpected ':', expecting '{' in ...../public_html/new-admin/vendor/guzzlehttp/guzzle/src/functions.php on line 14

Edit: Didn't see this type of declaration before of functions but it seems to be new from PHP 7...

sandervanhooft commented 4 years ago

You may be right. I am suspecting a Guzzle version is used that does not support your php version (5.6).

@Noordkust-nikolai can you share what's on line 14 of /public_html/new-admin/vendor/guzzlehttp/guzzle/src/functions.php?

Noordkust-nikolai commented 4 years ago

@sandervanhooft function describe_type($input) : string

sandervanhooft commented 4 years ago

then the Guzzle version is definitely the issue in combination with php 5.6. Any chance you can upgrade your php version to 7.2? @Noordkust-nikolai

Noordkust-nikolai commented 4 years ago

@sandervanhooft unfortunately not..

sandervanhooft commented 4 years ago

Can you try on your php 5.6 system:

Noordkust-nikolai commented 4 years ago

The old website is still in place and the new one in a subdirectory. So I would prefer not to have any interference with it.. How do I run that code? Make mollie-api-php.zip? And won't that have the same problem with the php versions of guzzle?

sandervanhooft commented 4 years ago

you can create another temporary directory for this test, clone the package there and run make mollie-api-php.zip from within the downloaded package directory.

Note that this requires a commandline (Linux/Mac), and composer globally available from the commandline (this is a typical webserver setup).

Running the makefile will pull in the dependencies that work for your setup, or notify you that it cannot be done. (so it would solve the guzzle version issue)

sandervanhooft commented 4 years ago

Hi @Noordkust-nikolai et al,

Can you give the latest release a try?