mollie / mollie-api-php

Mollie API client for PHP
http://www.mollie.com
BSD 2-Clause "Simplified" License
553 stars 191 forks source link

Complete documentation of Method status types #625

Closed BrechtBonte closed 2 years ago

BrechtBonte commented 2 years ago

See API documentation: https://docs.mollie.com/reference/v2/methods-api/get-method

The documentation of the different values for the "status" field is a bit ambiguous as it states type is "string" and the value "null" is documented the same as all other statuses. However, we received a response containing "status" => null.

In a strictly typed project this causes errors (which is how we discovered this). This extra documentation should make it clear that this is a valid case.

sandervanhooft commented 2 years ago

Thanks @BrechtBonte ! A bit ambiguous indeed.