Missing Fields in Capture PHP Class Relative to JSON Documentation

pepeh commented 7 months ago

Specifications

API Version: 2

Describe the issue

Upon integrating the Mollie API SDK for PHP, I noticed that there are discrepancies between the JSON response documented for captures and the Capture class in the PHP SDK. Specifically, there are fields present in the JSON response that are not available or represented in the Capture class, potentially leading to incomplete data handling or missing functionality for developers utilizing the SDK.

Identified Missing Fields

status: The JSON documentation includes a status field indicating the status of the capture (e.g., "succeeded"), but this field is not present in the Capture PHP class. This field is crucial for understanding the state of a capture.
metadata: The JSON example includes a metadata field that allows for the storage of additional information associated with the capture.

maria-swierblewska commented 7 months ago

Hi @sandervanhooft could you have a look into this?

sandervanhooft commented 7 months ago

Thanks for opening this ticket @pepeh !

I'll add the fields. Note that it will only help the IDE experience (autocomplete/hints) as Mollie's json response fields are assigned dynamically here.

sandervanhooft commented 7 months ago

Here it is!

https://github.com/mollie/mollie-api-php/releases/tag/v2.66.0

mollie / mollie-api-php