search

mollie / mollie-api-php

Mollie API client for PHP
http://www.mollie.com
BSD 2-Clause "Simplified" License
550 stars 189 forks source link

Enhanced methods.allActive() for integration consistency and added methods.list() #735

Closed sandervanhooft closed 1 month ago

sandervanhooft commented 2 months ago

This PR ensures integration consistency: methods.allActive() now returns the full set of activated methods regardless the currencies supported.

Context: Mollie added support for twint recently, which does not appear on /v2/methods by default because Twint does not support the EUR currency.

To mirror the API, the list() method is added for directly interacting with v2/methods.

$mollie->methods->list(); // Directly interact with the "/v2/methods" endpoint
$mollie->methods->allActive(); // Enhanced for consistency: returns all methods regardless the currencies supported
fjbender commented 2 months ago

methods.allActive() now returns the full set of activated methods regardless the currencies supported.

Should we consider this a "soft" BC-break? Or is the filter behavior retained when we specify e.g. amount and currency filter conditions?

sandervanhooft commented 1 month ago

Closing this for now