Closed andreashug closed 1 year ago
Hello @andreashug , thanks for reporting. This might an error due to misreading the urllib3 documentation. We will look into it.
@andreashug we just released version 3.4.0 of the library, with your fix to this issue.
Issue
The client does 9 retry attempts after
ReadTimeoutError
ifretry
is set (default). This is contrary to the parameter description which says that only connect errors trigger a retry. According to the API documentation, this behavior might lead to multiple charges of recurring payments if no idempotency key is set.Steps to Reproduce
I've tested this with
v2.13.0
but the code is the same inmaster
.Current Behavior
9 retries after
ReadTimeoutError
Expected Behavior
No retries after
ReadTimeoutError
Possible Implementation
Set
read
retries to0
when instantiatingurllib3.utils.Retry
in mollie/api/client.py