search

mollie / mollie-api-ruby

Mollie API client for Ruby
http://www.mollie.com
BSD 2-Clause "Simplified" License
81 stars 42 forks source link

Ruby 1.8+ or 2.00+ #2

Closed chriswnl closed 10 years ago

chriswnl commented 10 years ago

According to https://www.mollie.nl/betaaldiensten/modules this module is for Ruby 1.8 and up. Having downloaded and tried to require it, I got a naming error for __dir__ coming from Client.rb. This it seems was only introduced from Ruby 2.0.

Changing it to 

File.dirname(File.realpath(__FILE__))

fixed the issue for me in lines 15 and 60 of the current release.

RickWong commented 10 years ago

Chris, we're going to fix that line and also check the rest of the code. Thanks for helping us improve this module!

RickWong commented 10 years ago

Unfortunately I'm going to have to change the minimum required version from Ruby 1.8 to Ruby 1.9.2 because the REST Client or actually the mime-types rubygem requires that anyway.

Chris, which version of Ruby are you using?

chriswnl commented 10 years ago

Sorry I didn't see the followup. I was/am using 1.9.3 but I'm adaptable.