[11.0][FIX] API call to payments

mollie / mollie-odoo

Mollie Payments plugin for Odoo - an open source CRM and ERP

29 stars 50 forks source link

[11.0][FIX] API call to payments #130

Closed robinkeunen closed 6 months ago

robinkeunen commented 2 years ago

The API nows only returns a single data dictionary instead of a list. Also, the transaction id must be passed in the url.

Previously, data argument was overwritten in the function body. I'm tempted to either

keep overwriting the data dict in the case some other function relies on the content of the data dict
avoid overwriting the data dict as a best practice to avoid side effects.

I chose the latter option.

robinkeunen commented 2 years ago

@odoo-mvds can you have a look at this ? We've been using it in production for 3 months now.

odoo-mvds commented 2 years ago

Hello,

we do not support old versions anymore, however we will have a look at this fix as it's easy to merge. We'll give you an update soon.

br,

odoo-mvds commented 6 months ago

Hi,

Thank you for your contribution and for submitting the pull request (PR).

As we have informed you, we are no longer maintaining the older version of the project to which your PR applies. We recommend upgrading to the latest version. In case we receive more such complains for the same issue, we will probably reopen the issue. Consequently, we will be closing this PR.

We truly appreciate your effort and interest in improving the project and look forward to any future contributions you may have.

Best regards,