search

mollie / mollie-oxid

Mollie Payments for OXID eSales
7 stars 5 forks source link

Declaration of validatePayment not correct #8

Closed kiliankoller closed 3 years ago

kiliankoller commented 3 years ago

Hi, with version 1.0.18 we are seeing the following warning:

[Thu Mar 04 09:15:35.106435 2021] [proxy_fcgi:error] [pid 166059:tid 139828177786624] [client 173.0.81.65:59971] AH01071: Got error 'PHP message: PHP Warning: Declaration of Mollie\Payment\extend\Application\Model\Order::validatePayment($oBasket) should be compatible with OxidEsales\EshopCommunity\Application\Model\Order::validatePayment($oBasket, $oUser = NULL) in /srv/www/sportschrank_prod/source/modules/mollie/molliepayment/extend/Application/Model/Order.php on line 419'

Regards

markusmichalski-fc commented 3 years ago

Hi, thanks for the information. We will look into it. Kind regards

FatchipRobert commented 3 years ago

The method declaration was changed in Oxid 6.2 where the $oUser parameter was added.

I added a solution that keeps the module backwards compatible.