mollie / reseller-api

Reseller API voor het aanmaken en beheren van Mollie-accounts
https://www.mollie.com/
BSD 2-Clause "Simplified" License
13 stars 4 forks source link

Country of created Account is not respected in "welcome" e-mail #11

Closed holtkamp closed 7 years ago

holtkamp commented 7 years ago

When creating an Account for a Dutch company (country: NL), an e-mail is dispatched to the indicated e-mail address in the Dutch language: great!

The e-mail invites the recipient to activate the newly created Account, however, the activation link

points to an English version of the terms of Mollie to accept:

https://www.mollie.com/en/terms/sign?redirect_url=https%3A%2F%2Fwww.mollie.com%2Fdashboard%2F

I would expect the terms to be presented in the appropriate language (Dutch for companies in The Netherlands). If presented in English, I expect a lot of our resellers to become frightened / confused and NOT accept the terms...

Notes Changing the ?lang=en GET parameter in the activation URL to ?lang=nldoes not have any effect. Changing /en/ in the terms URL to /nl DOES have effect:

https://www.mollie.com/nl/terms/sign?redirect_url=https%3A%2F%2Fwww.mollie.com%2Fdashboard%2F

Also note the layout of the activation button in the e-mail seems incorrect, when comparing it to former e-mails (that pointed to a different URL as well, I guess you guys are migrating to the new dashboard)

Old e-mail layout (proper button and hyperlink formatting)

screen shot 2017-02-14 at 15 17 59

New e-mail layout (strange button and hyperlink formatting)

screen shot 2017-02-14 at 15 17 38

willemstuursma commented 7 years ago

Hi @holtkamp. We'll be resolving the language issue somewhere next week.

When did you start getting the error in email layout?

willemstuursma commented 7 years ago

We've made some changes. Can you confirm that everything is working correctly now?

holtkamp commented 7 years ago

Can you confirm that everything is working correctly now?

Well, it is a bit difficult to test 😄 , we need to create Reseller accounts for 'real companies', with real data for this to test. In general we do not have access to the mail-accounts of these companies. So for the time being I can not answer this question...

willemstuursma commented 7 years ago

OK, I'm going to rely on our internal testing then! Let me know if you figure out something is still not working as expected.

holtkamp commented 7 years ago

@willemstuursma due to the change in style of Mollie, we needed to update the screenshots in our documentation. I just created a new partner account to test. The locale seems respected, but the formatting is still "crazy" / incorrect: the button with the activation link is rendered incorrectly, at least in GMail and Amazon WorkMail web clients.

GMail:

screen shot 2017-04-24 at 10 40 19

Amazon WorkMail:

screen shot 2017-04-24 at 10 40 40

The Button does contain the proper URL though, only the formatting breaks.. Maybe this deserves a separate issue?

willemstuursma commented 7 years ago

Hi @holtkamp. Thanks for bringing this up, we're going to look into it.

holtkamp commented 7 years ago

@willemstuursma did you guys have a look? Any ETA on this? We are planning on creating Mollie partner IDs for a big amount of our customers...

willemstuursma commented 7 years ago

@holtkamp We're trying to get it fixed this week, sorry.

holtkamp commented 7 years ago

@willemstuursma ok, great, standing by and waiting for a heads-up 😄

holtkamp commented 7 years ago

@willemstuursma any news on this? ETA?

willemstuursma commented 7 years ago

@holtkamp I just got word this has been resolved by our team, I expect it will be deployed later today.