mollie / spree-mollie-gateway

Mollie payments for Spree Commerce.
https://www.mollie.com
16 stars 23 forks source link

Is MollieGateway compatible with other payment methods of Spree ? #101

Open nflorentin opened 3 years ago

nflorentin commented 3 years ago

Hi,

I was going to use Mollie for a client project but I'm facing an issue.

If I add other payment methods than Mollie, they don't seem to work well.

For example, If I add Spree::PaymentMethod::Check as a payment method, confirmation emails is not sent and inventory tracking is not done. I think the problem is caused by the fact that the gem spree-mollie-gateway overrides the finalize! method of Order class (here). This method seems tightly coupled with mollie logic but is also used by every order as soon as the gem is added in the bundle (no matter what payment method is used).

So my question is: Is it possible to activate other payment methods of Spree when using MollieGateway ? If not, that would mean that if I choose Mollie Gateway, I won't be able to activate bank check payment method for example.

Is it not possible to run the code of mollie finalize! method only if the payment method used is Mollie and use the default finalize! method of spree otherwise ?

Thanks in advance for your insight,

Have a nice day