search

mollie / spree-mollie-gateway

Mollie payments for Spree Commerce.
https://www.mollie.com
16 stars 23 forks source link

/admin/orders index crash #51

Closed sekretarot closed 5 years ago

sekretarot commented 5 years ago

Installing the spree_mollie_gateway 3.0.3 version breaks the orders index page in the backend on new spree install on version 3.1.x. We get a method missing error on store_id_in. Please see screenshots and let me know if you need more info.

screen shot 2018-12-03 at 2 13 51 pm

screen shot 2018-12-03 at 1 50 40 pm

vernondegoede commented 5 years ago

Hi @sekretarot, the minimum Spree version is 3.3.x, since the gateway depends on the Spree::InventoryUnits model.

sekretarot commented 5 years ago

Hi @vernondegoede

Ok, fair enough. We will look into a way to fix it.

But are you guys sure that this also works with version 3.3?

The issue is because the view assumes that the "store" relation on the order model is ransackable.

This got added to spree in this commit which was added starting from 3.5.0rc.

Maybe I'm missing something but if this is the case you might want to raise the spree dependency to 3.5 or maybe we can add this to the gem if you are willing to support older versions.

I can add a PR for this but I am not sure how you guys want to approach this.

vernondegoede commented 5 years ago

Sorry @sekretarot. You're right. The minimum Spree version should be 3.5.x instead of 3.3.x. Updated the README to reflect this.