search

mollie / spree-mollie-gateway

Mollie payments for Spree Commerce.
https://www.mollie.com
16 stars 23 forks source link

Compatibility issue with spree 3.6/3.7 #81

Closed dbbooke12 closed 4 years ago

dbbooke12 commented 4 years ago

Seems to be a comtability issue with spree 3.6 and 3.7 with spree_mollie_gateway 3.2.

I’ve installed a fresh spree 3.7.3, Rails 5.2.3, Ruby 2.5.3 and I’m getting both these errors when install the gem and generator. I’ve noticed tickets in the past regarding this issue but doesn’t seem to be fixed? Not sure.

B4E05D65-2C67-4FE6-A9E1-46640623754C

10DBA7C1-2E7E-45F3-9B56-63904C60FEDE
vernondegoede commented 4 years ago

@FabianOudhaarlem Can you take a look? This probably happens because there's >= 1 payment(s) in the DB already, but the Spree Mollie Gateway isn't enabled yet (which is also not possible, as the admin breaks).

@dbbooke12 Can you confirm this theory?

Oldharlem commented 4 years ago

@vernondegoede I will have a look

dbbooke12 commented 4 years ago

That's exactly what it was @vernondegoede . When you install spree by default they run sample data during the generators and i think it generates some sample orders.

When I disabled the sample data/seeds I no longer got the error in admin/orders for "undefined method status". However, during checkout the payment forms still does not show up. I have set up all shipping methods, countries, states for billling as well but still no form.

vernondegoede commented 4 years ago

Thanks for the confirmation @dbbooke12! Just to be sure, did you also set up the payment method within the admin? And set the correct API key, specify visibility ("Both"), etc?

dbbooke12 commented 4 years ago

@vernondegoede That is correct. I have setup the correct API keys and vibisility. I have provided you with an image.

Screen Shot 2019-09-18 at 11 21 08 AM
vernondegoede commented 4 years ago

@dbbooke12 Thanks a lot! Very useful.

Don’t forget to reset your test API key in our Dashboard, as it’s now publicly available.

dbbooke12 commented 4 years ago

First thing I did haha. Thanks! Any idea what could be causing this? @vernondegoede

dbbooke12 commented 4 years ago

any update on this

Oldharlem commented 4 years ago

Hi @dbbooke12 I have looked into the issue and found conflicting code on the admin order index page. The status method of the mollie payment source was being called on all orders independent of payment method. PR #82 fixes the issue.

The other issue you were experiencing on the checkout does not occur for me. I have created a project with mollie installed. Spree 3.7.3 ruby 2.5.1 and rails 5.2.3 I linked it below.

spree 3.7.3 mollie

vernondegoede commented 4 years ago

We just released version 3.2.1, which includes the fix for the crashing admin overview page.

@dbbooke12 Can you let us know if this resolved the issue? And could you help us pinpoint the root cause of the checkout issue?