mollie / spree-mollie-gateway

Mollie payments for Spree Commerce.
https://www.mollie.com
16 stars 23 forks source link

Outdated documentation missing 'Auto Capture' #87

Closed DianaLaa closed 4 years ago

DianaLaa commented 4 years ago

What is the recommended value for Auto Capture?

image

I'm not entirely sure but if we set it to false, I believe we need to do manual actions. Could you perhaps also clarify what these manual actions consist of?

Oldharlem commented 4 years ago

Hi @DianaKoenraadt

The auto capture option on the payment method is ignored and originates from the spree implementation of active merchant. In the mollie_gateway.rb:39 you'll find the auto_capture option is fixed to true.

By default the mollie gem is configured to auto_capture_on_dispatch which means on dispatch of a shipment the payments associated to the package contents are auto captured.

Capturing for most payment gateways is meaningless. Although for example after pay payments require a capture event to retrieve the funds. The auto_capture_on_dispatch setting takes care of this automatically and I would advice against disabling this and manually capturing payments where possible.

DianaLaa commented 4 years ago

Thanks for your reply. So, if I understand correctly:

Is that the correct summary?

Oldharlem commented 4 years ago

You are mostly right.

The capture is being executed on dispatch of the shipment, so when you click ship in the spree backend for example. On 21 Mar 2020, 11:53 +0100, Diana Koenraadt notifications@github.com, wrote:

Thanks for your reply. So, if I understand correctly:

• Capture is the action Mollie does after the customer has said "Sure, I'll pay" (=authorization). Capturing is the actual money withdrawal, right? • In most payment methods, there is no difference between authorization and withdrawal. But as I understand, for Credit Cards, you need capture. • And you guys have set auto-capture to true in your plugin, so that the webshop don't have to do it manually. If the customer authorizes, you capture automatically. • But you don't do this until the package is shipped?

Is that the correct summary? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

DianaLaa commented 4 years ago

Thank you for your reply, much appreciated.

Feels like that's what I said: we click that we've shipped the package and then the payment is captured. Am I missing a detail in my understanding? (Note: We've just started digging through Spree so I'm not well versed yet.)

Could you perhaps clarify why the capture isn't done immediately? Is this a technical or legal decision?

Oldharlem commented 4 years ago

From your explanation i thought i understood you were asking when the capture event is triggered. This is done at shipment.

As far as i know only creditcards and after pay payments are legally required to be shipped before they can be captured.

Maybe @vernon can elaborate more on the specific capture rules per payment gateway. On 21 Mar 2020, 12:06 +0100, Diana Koenraadt notifications@github.com, wrote:

Thank you for your reply, much appreciated. Feels like that's what I said: we click that we've shipped the package and then the payment is captured. Am I missing a detail in my understanding? (Note: We've just started digging through Spree so I'm not well versed yet.) Could you perhaps clarify why the capture isn't done immediately? Is this a technical or legal decision? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

DianaLaa commented 4 years ago

Thanks, that clears it up for me! I knew about after pay like Klarna. Didn't know the same held for credit cards. My initial question is answered, I understand the Auto Capture function now. Thanks!

Oldharlem commented 4 years ago

Happy to help :)