mollyim / mollyim-android

Enhanced and security-focused fork of Signal.
GNU Affero General Public License v3.0
1.58k stars 86 forks source link

Bring back the colors #222

Open JohnnyZig opened 12 months ago

JohnnyZig commented 12 months ago

Is there an existing request for this?

Feature description

Signal before 2021.08. had single color for my messages (gray) and color per contact (in groups and one-to-one communication). To me it is much easier to distinguish when every person has its color and my messages are always in grey bubble. There are some interest in having that back: https://www.reddit.com/r/signal/comments/nmaxfi/losing_contact_colours_on_android/ https://www.reddit.com/r/signal/comments/o1l5vd/megathread_discuss_the_recent_color_changes/ etc

Could we have at least a toggle button to return to old, sane colors? Please

Dobli commented 11 months ago

Would also like that. I was using a custom patch on top of Signal the past months that reverted the colors, it is like 20 lines of changes and works almost perfectly already. Even group chats work as expected with individual colors for each participant just like before. Only just recently it became a bit buggy in group chats with the changes of Signal moving more components to Kotlin. I will try to apply my changes on top of Molly the next days, could be a first starting point for discussions for a proper solution I guess.

Dobli commented 11 months ago

So I applied my patches to Molly and it works the same as it did on Signal. Colors get applied to the incoming chat bubbles according to the selected chat color. Same color is also used within group chats. But also has the same regression like the latest Signal version in group chats. In these, the colors in group chats are not applied right away. Initially all incoming messages use the default color, only on update (scrolling, or receiving/sending messages) the colors get applied.

In case anyone wants to try it out, I placed my branch here.

m-boyd commented 8 months ago

@Dobli Did you find a solution to that regression?

Dobli commented 7 months ago

Sorry for the late reply, unfortunately not, it broke even more with more recent versions. I guess I try it again when most parts of the conversation UI are migrated to kotlin (seems the related refactoring introduced these regressions).