search

mollyim / mollyim-android

Enhanced and security-focused fork of Signal.
GNU Affero General Public License v3.0
1.37k stars 78 forks source link

"Verify your Signal PIN" stuck in endless loop #229

Open ilu33 opened 8 months ago

ilu33 commented 8 months ago

Is there an existing issue for this?

Bug description

The "Verify your Signal PIN" window is stuck in the middle of the screen. I can click it, enter the correct PIN, but the windows stays and the app becomes unresponsive. Restarting the app results in again displaying the "Verify your Signal PIN" window.

Steps to reproduce

  1. Install Molly-Foss from the Molly repo
  2. Start Molly-Foss
  3. Register
  4. Use the app until the "Verify your Signal PIN" event displays for the first time
  5. Get stuck or disable PIN reminder.

Molly version

v6.35.3-1 FOSS and before

Android version

9, custom ROM

Device

Moto G4

Link to debug log

It's not clear whether I can review the debug log before sending it - that's why I have disabled the log function.

muellerto commented 5 months ago

I found this in the original Signal. And I have had it there over several releases. Indeed this is the main reason why I don't use the original Signal anymore. It's probably not a Molly problem.

valldrac commented 5 months ago

@muellerto Thanks for letting us know about this.

Could you please share the Signal version you were using when you last found this issue, or if you remember roughly when it happened?

muellerto commented 5 months ago

I had this in all Signal releases since ... don't remember ... 6.37 (?) or so, or even earlier, quiet for a while. And I think it's still there. I don't have a Signal currently, but when I install a new one I have it immediately.

The dialog for verifying the PIN doesn't have any control for a successful confirmation, there's only a cancel button. The following picture from the Sinal website shows a blue button which is then not there:

signal-pin-android-3

When it still did work I switched the PIN verification always off, but since the dialog behaves like this I can't anymore. So the PIN verification must remain on and that's indeed annoying because this number is rather useless but gets an importance here it never had.

This happens also in recent Langis releases.

My device is a Fairphone 3+ running /e/ 1.19.1 on Android 12.

valldrac commented 5 months ago

I don't have a Signal currently, but when I install a new one I have it immediately.

If you install it and still encounter the error, please capture the debug log (in Settings > Help) and post the link here, or send it to support@molly.im. I'll report the bug to Signal.

When it still did work I switched the PIN verification always off, but since the dialog behaves like this I can't anymore. So the PIN verification must remain on and that's indeed annoying because this number is rather useless but gets an importance here it never had.

At least with Molly, it doesn't ask you to confirm the PIN to turn off the reminder.