search

mollyim / mollyim-android

Enhanced and security-focused fork of Signal.
GNU Affero General Public License v3.0
1.37k stars 77 forks source link

Order of pinned messages gets messed up after adding secondary Molly device #266

Closed taivlam closed 2 months ago

taivlam commented 5 months ago

Is there an existing issue for this?

(This issue occurred in parallel with #259. This is also different from issue #264.)

Bug description

The order of pinned chats on primary Molly devices is lost after adding a secondary Molly device. There isn't really a pattern that I can discern.

I have 3 one-on-one chats made in 2022 (or earlier) and 1 group chat made in 2023 (but before quantum resistance was introduced). I'm not sure if creation date really matters, but I've noticed that the newest group chat is the only conversation left pinned after adding a secondary Molly device. I've observed this issue ever since when Molly started offering linking secondary Android devices in 2023.

Whenever the secondary Molly device is added, this will mess up the order of pinned chats to be the same on the main Molly device and also any linked Signal Desktop devices.

I've tried correcting the order of pinned chats on the linked devices (both secondary Molly device and Signal Desktops) when this first happened back when secondary Android devices were added into Molly on September 14, 2023 (version v6.31.2-1) and also when multi-device worked again after issue #219 was resolved for version v6.41.3-2.

I can rearrange the pinned chats just fine on the main Molly device, yet the linked devices will somehow not acknowledge the change. However, once I start fixing the order on the linked devices (either secondary Molly or Signal Desktop), this introduces a whack-a-mole situation: the chat I pin on secondary devices will become unpinned on the primary Molly device. (I haven't tried playing "whack-a-mole" again with pinned chats on linked devices after mid-December 2023.)

Steps to reproduce

  1. Set up 4 pinned chats (which is apparently the maximum, according to feature request issue #248) to see the most effect on the main Molly device.
  2. Link secondary Molly device.
  3. After secondary device linking is complete, examine the pinned chat list on the main Molly device.

Molly version

v6.41.3-2

Android version

Android 14, latest version of GrapheneOS at the time (2024010400)

Device

Link to debug log

Below are debug logs: my main Molly device is the Pixel 5a (barbet) and my secondary Molly device is the Pixel Tablet (tangorpro).

Before removing secondary device to fix issue

(These are the same debug logs from issue #259. Also, apologies in advance for the incomplete issue upon initial submission - I accidentally pressed the Enter key too early.)

taivlam commented 5 months ago

This started again about 3 days ago, though it also happened today.

I observed this issue occurs on my main Molly device within 10 minutes after my secondary Molly device is online.

Pinned messages get messed up

cyrneko commented 4 months ago

It seems this also happens for other settings, like typing indicators and read receipt settings.

taivlam commented 4 months ago

So far, I've observed that my secondary Molly device respects my settings for typing indicators & read receipt.

(Then again, I've turned those options off ever since they were available back on the website Signal APK.)

taivlam commented 3 months ago

Today

When I added a new Signal Desktop device today, I experienced this issue again. I thought this issue disappeared after Molly reached version 7.x.x (i.e., usernames available on stable production Signal), but this was not the case. Here are the debug logs for the devices used today:

Yesterday

Also, I experienced this issue yesterday, after unlocking Molly on my secondary Molly device after a while of being locked: