mollyim / mollyim-android

Enhanced and security-focused fork of Signal.
GNU Affero General Public License v3.0
1.58k stars 86 forks source link

Can't choose backup folder #281

Open afath-richard opened 7 months ago

afath-richard commented 7 months ago

Hello,

While this is possible in Signal, one cannot choose a backup folder for the conversations in Molly. Looks like a regression.

This is true untill Molly version 6.45.2-1-FOSS.

This is a problem since many people want to keep they full history.

But it takes so much disk space that there not enough room left for backups on the phone.

Migration to another phone is therefore impossible.

Thanx

valldrac commented 6 months ago

Could you provide a debug log? We need more detailed information.

Are you experiencing difficulty accessing the menu to choose a backup folder? Or perhaps you're able to select a folder, but it doesn't seem to work afterward?

In the latter case, it's possible that there's an issue with permissions to access that location. This could be due to a bug where the app never requests permission, or it could be revoked somehow.

afath-richard commented 6 months ago

Hi,

Thanx for answering. How do I get a debug log? In the meanwhile, here's a screencast of what happens when I want to backup:

As soon as I accept the backup option, the backup starts leaving no choice but canceling it, since it cannot finish.

You'll see that every button work except the path button which is not responding.

https://transfer.idoc.fr/2024/mobile_20240320_005706.mp4 (edited to add the cursor position).

There should be no permission problem since the backup starts and I'm able to save documents from conversations.

I've tried many times but I don't have enough time to trigger the button before the backup starts.

Did I miss something?

Regards

valldrac commented 6 months ago

Thanks for the video. I think I understand the issue now. It's not possible to select the backup destination folder while the backup is running. I'll fix it soon.

In the meantime, as a workaround, you can either wait for the backup to finish with an error, then choose the folder, or force quit the app and change the folder then.

afath-richard commented 6 months ago

Thank you, Oscar.

I had tried some workarounds before but none worked.

In case you'd allow changing the backup folder while it's running, why not prevent the automatic start of the backup instead (the way it works on Signal as far as I remember)? It might be simpler to revert to Signal's default behavior for this part of the code.

Anyways, I'm sure you'll find the best solution to fix most of the possible problematic situations.

I'm not in a hurry now, and I cannot help much more. I'll wait for the corresponding release. I know it might not be the next one, no worries!

Thanks for your work. Regards.

arsene-glanum commented 3 months ago

Hello,

I've been planning to install a better ROM. I really wish I could import my conversations post-install.

So I've tried again to backup with your suggested workarouds, but none worked.

Strangely, it's still impossible to choose the backup folder. Still nothing happens when choosing the option while the backup is not running anymore.

Therefore there is no workaround.

Best luck for the fix, and best regards