mollyim / mollyim-android

Enhanced and security-focused fork of Signal.
GNU Affero General Public License v3.0
1.37k stars 77 forks source link

Material You dynamic colors support #300

Open BigPebble123 opened 3 months ago

BigPebble123 commented 3 months ago

Is there an existing request for this?

Feature description

Hi! 👋🏻

Could you please implement this? https://github.com/nekorubu/Signal-You

I know that someone already created a feature request for Marerial You upport and @valldrac replied that Signal's team is already working on it, but that was in 2022 (almost 4 years ago).

Recently @nekorubu has created his own fork that adopts Material You dynamic theming and it would be great to implement it in Molly.

hndrk-themer commented 3 months ago

True, this would be a great addition to create a way more consistent look and imho, not that hard to achieve (am using an overlay rn on Molly, but stock for all people would be the best ofc).

Signal added Material You on their general layout, but i would love to see a "dynamic" option on the bubbles and related UI elements as well

Basic Info: https://m3.material.io/styles/color/system/how-the-system-works

The Figma Material Theme Builder Plugin is very useful for testing (set to Dynamic): https://www.figma.com/community/plugin/1034969338659738588/material-theme-builder

Basic M3 color attributes: https://github.com/material-components/material-components-android/blob/master/docs/theming/Color.md

katherine-maxwell commented 3 months ago

I would also quite like this dynamic theming. I wanted to note that the particular colors chosen in the nekorubu Signal-You fork could use some adjusting for better contrast. In particular, the bottom nav bar has poor contrast. Hopefully Molly can have an improved Material You implementation.

nekorubu commented 3 months ago

I wanted to note that the particular colors chosen in the nekorubu Signal-You fork could use some adjusting for better contrast. In particular, the bottom nav bar has poor contrast. Hopefully Molly can have an improved Material You implementation.

I'd like to think that's because I'm using Repainter for my Material You colors, and with the adjustments I made, the neutral colors don't have as much contrast. I did try to stick with the Material You guidelines as much as I could, though

katherine-maxwell commented 3 months ago

I wanted to note that the particular colors chosen in the nekorubu Signal-You fork could use some adjusting for better contrast. In particular, the bottom nav bar has poor contrast. Hopefully Molly can have an improved Material You implementation.

I'd like to think that's because I'm using Repainter for my Material You colors, and with the adjustments I made, the neutral colors don't have as much contrast. I did try to stick with the Material You guidelines as much as I could, though

To explain with pictures, using the same color theme on my phone for all screenshots:

Signal-You appearance: signal-2024-03-26-23-39-49-335-4

Clock-You appearance: signal-2024-03-26-23-39-49-335-5

However, some apps appear differently, example is Jerboa (using ColorBlendr to select Rainbow and Vibrant variants): signal-2024-03-26-23-39-49-335-2 signal-2024-03-26-23-39-49-335-1

hndrk-themer commented 3 months ago

If it's getting implemented right, i would definetely stick to the material 3 guidelines. so it matches the whole material 3 ecosystem. everything else can get customized by the user.

nekorubu commented 3 months ago

To explain with pictures, using the same color theme on my phone for all screenshots:

Signal-You appearance: signal-2024-03-26-23-39-49-335-4

Clock-You appearance: signal-2024-03-26-23-39-49-335-5

However, some apps appear differently, example is Jerboa (using ColorBlendr to select Rainbow and Vibrant variants): signal-2024-03-26-23-39-49-335-2 signal-2024-03-26-23-39-49-335-1

Ohhh, I see now. I'll try to find some time to change the colors on my fork. Thanks for the feedback!

Fernan181 commented 2 months ago

Any plans to get a pr for this? I would really love to see this feature implemented into Molly.

nekorubu commented 1 month ago

To explain with pictures, using the same color theme on my phone for all screenshots: Signal-You appearance: signal-2024-03-26-23-39-49-335-4 Clock-You appearance: signal-2024-03-26-23-39-49-335-5 However, some apps appear differently, example is Jerboa (using ColorBlendr to select Rainbow and Vibrant variants): signal-2024-03-26-23-39-49-335-2 signal-2024-03-26-23-39-49-335-1

Ohhh, I see now. I'll try to find some time to change the colors on my fork. Thanks for the feedback!

I finally implemented this in the most recent release of Signal-You

Fernan181 commented 1 month ago

@nekorubu great! Any chance we see a pr from you implementing your changes? I'd really appreciate it.

katherine-maxwell commented 1 month ago

@nekorubu Thanks for your changes. While the bottom bar is clear now, the highlight for the active tab is still quite poor. This in particular bothers me, because I look for the highlight color to know which tab I am on. Screenshot_20240516-183300_1g

From what I understand, there is a default material 3 color for elements. See https://m3.material.io/components/navigation-bar/specs. Also, I believe the elevation affects the color slightly, see https://m3.material.io/styles/elevation/tokens.

If/when I have free time I can look at the code myself and try to adjust it.

nekorubu commented 1 month ago

@nekorubu Thanks for your changes. While the bottom bar is clear now, the highlight for the active tab is still quite poor. This in particular bothers me, because I look for the highlight color to know which tab I am on. Screenshot_20240516-183300_1g

From what I understand, there is a default material 3 color for elements. See https://m3.material.io/components/navigation-bar/specs. Also, I believe the elevation affects the color slightly, see https://m3.material.io/styles/elevation/tokens.

If/when I have free time I can look at the code myself and try to adjust it.

Oh, I see what you mean. When I made the change, I mainly just eyeballed it until it looks right, which is quite ironic given that when I last made changes, I tried to go off of the guidelines. On top of that, I was using Repainter for my colors, so while the colors looked fine, now that I'm using colors that stick to the Material You spec, I can see where the contrast is still lacking. Thanks again! I'm running a build through GitHub to hopefully get a test version now.

nekorubu commented 1 month ago

@nekorubu great! Any chance we see a pr from you implementing your changes? I'd really appreciate it.

I'll try when I get the chance. I don't know if there's a difference in how Molly implements the colors in the code, so I'll have to check it out myself.

resucutie commented 3 weeks ago

hello! any updates on implementing material you on molly? we're all interested in this feautre being implemented