search

mollyim / mollyim-android

Enhanced and security-focused fork of Signal.
GNU Affero General Public License v3.0
1.65k stars 89 forks source link

signalbackup-tools: [Error]: Failed to get valid frame from decoded data... #371

Open XSm2i opened 4 weeks ago

XSm2i commented 4 weeks ago

Is there an existing issue for this?

Bug description

https://github.com/bepaald/signalbackup-tools

I get this error when decoding a backup created by version v7.13.4-1 & v7.17.5-1. I haven't tested earlier versions.

Reading backup file: 099.6%... [Error]: Failed to get valid frame from decoded data... Data was verified ok, but does not represent a valid frame... Don't know what happened, but it's bad... :( Decrypted frame data: (hex:) 1a ... 00 [Warning]: SKIPPING INVALID FRAME! Reading backup file: 100.0%... done! Database version: 247

It doesn't make a difference if I disable the passphrase lock, the result is the same. Upstream backups decode without issue.

Backups reporting the valid frame issue restore fine (in my limited testing) on upstream installs.

Steps to reproduce

Register a fresh install, create a backup, decode it.

Molly version

7.17.5-1

Android version

No response

Device

No response

Link to debug log

No response

XSm2i commented 5 days ago

One thing I neglected to say is that to replicate you need to enable the passphrase lock before registration. If you don't, this issue doesn't occur. So something irreversible happens.

As I said, if you disable it after registration the issue is still present.