search

molmod / yaff

Yaff is yet another force-field code
http://molmod.github.io/yaff
GNU General Public License v3.0
31 stars 18 forks source link

Lammps library bugfixes #54

Closed stevenvdb closed 5 years ago

stevenvdb commented 5 years ago

This PR fixes a memory leak and a concurrency issue in the Lammps library interface. Unfortunately such mistakes are hard to detect with the current unit tests.

codecov-io commented 5 years ago

Codecov Report

Merging #54 into master will increase coverage by <.01%. The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   82.31%   82.31%   +<.01%     
==========================================
  Files          94       94              
  Lines       13958    13975      +17     
  Branches     1934     1937       +3     
==========================================
+ Hits        11489    11504      +15     
  Misses       2027     2027              
- Partials      442      444       +2
Impacted Files Coverage Δ
yaff/external/liblammps.py 84.57% <92.59%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d036bb...42963aa. Read the comment docs.