search

molnarg / node-http2

An HTTP/2 client and server implementation for node.js
MIT License
1.79k stars 187 forks source link

removing unnecessary files and directories from npm pkg #186

Closed ipetez closed 8 years ago

ipetez commented 8 years ago

I would recommend adding a these files/dirs to the .npmignore file since they are unnecessary for the user downloading the package and they can still get these files and directories by cloning the repo.

nwgh commented 8 years ago

Thanks! I agree about the tests and the travis config - I'm not so convinced about excluding the example (in my mind, it goes along with the README as "useful documentation to have").

If you'd like to update the PR, I'd be more than happy to accept this with that change, otherwise I'll just roll my own copy of this up into my next batch of commits (and credit you in the commit message).

ipetez commented 8 years ago

@nwgh Yeah that thought did cross my mind but decided to exclude it. But I do agree with you that it might be great to keep the examples in the package. I will update the PR. Thanks!

ipetez commented 8 years ago

@nwgh Just updated my PR and squash the 2 commits.

nwgh commented 8 years ago

Awesome, thanks!

ipetez commented 8 years ago

:+1: