search

molnarg / node-http2

An HTTP/2 client and server implementation for node.js
MIT License
1.79k stars 187 forks source link

Fix http2 agent doesn't work with request module #197

Closed felicienfrancois closed 8 years ago

felicienfrancois commented 8 years ago

Fix #174

nwgh commented 8 years ago

This looks good, but it also needs fixed in getTLS

felicienfrancois commented 8 years ago

I have also applied the fix to requestRaw and getRaw because even if in current implementation the agent option of Agent.prototype.request does not seems to be handled in plain mode (is it?), it may change in the future.

felicienfrancois commented 8 years ago

I just checked that test are passing. We should normally add tests for this fix but I have not the time to do it now. I may do it next week

nwgh commented 8 years ago

Thanks! This also continues to pass the Firefox integration tests, so it's good to go in my book.