search

molnarg / node-http2

An HTTP/2 client and server implementation for node.js
MIT License
1.79k stars 187 forks source link

Allow frames to send after the arrival of the RST_STREAM. #210

Open adamhenson opened 7 years ago

adamhenson commented 7 years ago

Prevent exceptions for the common case in which the serving endpoint sends frames after the RST_STREAM has been sent from the client endpoint. Often frames are enqueued prior to the arrival of the RST_STREAM, but sent after. This should be expected based on HTTP/2 spec, section 6.4.

https://http2.github.io/http2-spec/#rfc.section.6.4

"However, after sending the RST_STREAM, the sending endpoint MUST be prepared to receive and process additional frames sent on the stream that might have been sent by the peer prior to the arrival of the RST_STREAM."

Pupix commented 7 years ago

Can confirm it's working for me too. Thanks!

bjb568 commented 7 years ago

@nwgh http2 is unusably crashy, this PR fixes that. When will it be merged?

lujjjh commented 7 years ago

When will it be merged?

benjamingwynn commented 7 years ago

This should be merged. It's been months.

75lb commented 7 years ago

works for me too, thanks - i can push multiple resources now..

hthetiot commented 6 years ago

merged https://github.com/kaazing/node-http2/commit/9420db76401f73372c4f6d9d9b30d5553ea313eb