molnarg / node-http2

An HTTP/2 client and server implementation for node.js
MIT License
1.79k stars 187 forks source link

memory leak fix (by argon) and another 'upstream is not defined' check #222

Open simllll opened 7 years ago

simllll commented 7 years ago

this PR contains Clean up ended streams to free leaked memory #200 and an additional check if stream is defined. (line 314)

without these changes I was not able to run this code for a longer time. I use this in production, should be well "tested".

AndrewBarba commented 7 years ago

@simllll Are you still using this in production? Looking at just hosting a zip and referencing from my own package. Can't believe no movement here...

simllll commented 7 years ago

Hey Andrew,yes still using it. True that,not sure what happened to the repo owner?!

haozxuan commented 7 years ago

hope merge as soon as possible

hthetiot commented 6 years ago

was merged via https://github.com/kaazing/node-http2/commit/db0936244be639cbfd9a45c85377d0923a123b46