search

molnarkares / kicad-tinbox

KiCad plugin to generate PCBs fitting in tin boxes
Apache License 2.0
6 stars 1 forks source link

Round corners #1

Open leoheck opened 11 months ago

leoheck commented 11 months ago

Nice project. It would be nicer if you could put a round corner in the internal edges of the base too. And also a small chamfer to break the sharp edges.

molnarkares commented 11 months ago

Added rounding on internal edges and bottom on changeset 03eaaad058c38e44d8963ac5fbdadb2ba05f741d

molnarkares commented 11 months ago

@leoheck Thank you for the feedback! If you would like to try it, please use the r0.3 release that has an install ZIP.

leoheck commented 11 months ago

@molnarkares I tried to load your open scad model, but this mounting_pad_cfg.scad file is missing. I would like to show you the aesthetic refinements I was thinking about. Could you please share with me the exported .step file of the initial version?

molnarkares commented 11 months ago

@leoheck please find a sample config attached. I have included the included config and an exported STL, too. The included config is a generated file with the parameters for the OpenSCAD model. It is normally created during the execution of the plugin for the given PCB size.

mounting_pad_cfg.zip

leoheck commented 11 months ago

Ah, I have to generate it! Thanks.

molnarkares commented 11 months ago

@leoheck you're welcome. I can reopen the issue in case you have major concerns with the updated OpenSCAD model.

leoheck commented 11 months ago

I still have to generate this to give it a try. But I can open the issue too if needed. I just need some time to play with it.

leoheck commented 11 months ago

How do you launch this? Isn't it a python script? I Do you call it a plugin because we have to run it from Kicad? I am kind of confused. I landed here from another site...

leoheck commented 11 months ago

Anyway, I could open the zip you sent above. It has a .stl. No please, do the user a favor, and export the .step file instead. Step file is better.

leoheck commented 11 months ago

Also, tryed the mounting_pad_cfg.scad you sent me, but it does not create the same image you put in the README. The stl is not good to since you gave the updated version with rounded corners. I would like to have the initial version with right angles so I can improve it a bit. But the step file.

leoheck commented 11 months ago

Thanks for your patience dude. I was thinking something like this. It is a bit more smooth and aesthetically pleasing.

image

image

molnarkares commented 11 months ago

I am re-opening the issue to continue the conversation. @leoheck thank you for the effort to update the design to demonstrate your request. Well, I would say I partially agree:

  1. You requested chamfered/rounded bottom, and I agree to this request. Not to make it looking better, but to accommodate the fact that the tin box walls are not bent in very sharp edges - so a sharp edged bottom might not lay flat in the box. This is already implemented in the latest update.
  2. You requested rounding in the internal cut-out, and I agree to this request - again not because it looks better, but it is easier to manufacture with FDM printers. This is already implemented in the latest update.
  3. I see rounding on your picture where the screw bases are connected to the base body of the mounting pad. I may think this could add extra strength, this may be supported, will think about it. Not implemented yet.
  4. Chamfering/rounding on the upper outer edge of the base body, the top and the hole of the screw base, and in the internal cut-out: I kind of think that these cannot be justified with robustness, manufacturability or technical reasoning, i.e., these are rather cosmetic changes. I would not be against it, however : while these may be just a few clicks in a mechanical CAD tool, it is pretty complicated to model it via OpenSCAD algorithmically. Especially the chamfering of the internal cutouts... If you open the OpenSCAD program with a text editor then you see it is already rather complicated. I just feel that the benefits and the cost to implement are not proportional on a component that is inherently invisible after installation....
leoheck commented 11 months ago

I see rounding on your picture where the screw bases are connected to the base body of the mounting pad. I may think this could add extra strength, this may be supported, will think about it. Not implemented yet.

This is not necessary, I added it as a lazy step since I selected the bosses base to make the chamfer, so Freecad put the chamfer on all the edges of this object. I should have selected just the inner/outer edgers but not the edges of the bosses. It is not necessary.

I made my 3d model using Freecad, and with Freecd you can also have a customizable 3d model. I am sharing my design with you, however, my design is not customizable, but it can be converted to it, easily using the Spreadsheet Workbench. It is just a quick thing to show what I was thinking about.

altoid_mount.zip

In this version, I removed the chamfer on the bottom edge of the bosses. I also improved the radius of the internal fillets to be more aesthetically pleasing (for me)