molobrakos / lms-mobileskin

Mobile/resposive skin for Slimserver (Logitech media server)
20 stars 4 forks source link

Album art + song info not updating when playing playlist #9

Closed bakker closed 6 years ago

bakker commented 6 years ago

Did some more testing in my envrionment & use case and found the following: If I fill up the playlist manually the cover image + song info (title + artist) stays on the first track for as long as the playlist lasts If I let LMS give me 1 random song or album and let Spicefly SugarCube take over from there all info changes according to the playing song

I haven't tried yet with "Don't stop the music", but I'm fairly certain this wil work correctly as well. It seems to me that this interface doesn't know about changing tracks when they're from a playlist.

molobrakos commented 6 years ago

Is this 100% reproducable for you? Can you please provide the exact steps needed to reproduce?

Something like:

  1. In default ui 1a. make sure playlist for player is empty 1b. then manually add 3 tracks
  2. In mobile skin 2a. Select player screen (same player as above) 2b. Press play 2c. Wait for first song to end 2d. Observe next song starting 2e. Observe cover image, song info not updating

(which does not reproduce the bug for me, i.e. the cover image and song info updates as expected)

bakker commented 6 years ago

Hello, Yes it's 100% reproductible. Attached the screenshots of the results from your scenario. Comments in order of pictures:

  1. Playlist created in default web UI, playback started
  2. First song finished, second song started playing, displayed cover + song info remains identical
  3. second song is quite a lot longer than first, running & remaining time do update, total time doesn't
  4. Second song finished, Spicefly SugarCube kicked in to add a fourth song, cover and other info for third song is now correctly displayed
  5. Fourth song, added by Spicefly Sugarcube) playing and dsiplaying correctly

grtz, Bart Kestelyn

On Fri, Feb 16, 2018 at 6:43 PM, Erik Eriksson notifications@github.com wrote:

Is this 100% reproducable? Can you please provide the exact steps needed to reproduce?

Something like:

  1. In default ui 1a. make sure playlist for player is empty 1b. then manually add 3 tracks
  2. In mobile skin 2a. Select player screen (same player as above) 2b. Press play 2c. Wait for first song to end 2d. Observe next song starting 2e. Observe cover image, song info not updating

(which does not reproduce the bug for me, i.e. the cover image and song info updates as expected)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/molobrakos/lms-mobileskin/issues/9#issuecomment-366306791, or mute the thread https://github.com/notifications/unsubscribe-auth/AAInlVBhIteMJ6_yy8Xistm01NOk6z9Dks5tVb45gaJpZM4SIXCA .

-- “Be who you are and say what you feel because those who mind don't matter and those who matter don't mind.” Dr. Seuss

bakker commented 6 years ago

20180216_mobileskin_01 20180216_mobileskin_02 20180216_mobileskin_03 20180216_mobileskin_04 20180216_mobileskin_05

bakker commented 6 years ago

Sorry, first timer ...

molobrakos commented 6 years ago

Maybe fixed by this: https://github.com/molobrakos/lms-mobileskin/commit/7b6790d71da3e835399e61cf95f02857102f67f5

molobrakos commented 6 years ago

Closing, please reopen if issue still present.