search

molobrakos / volvooncall

Retrieve information from the Volvo On Call (VOC) web service
The Unlicense
151 stars 47 forks source link

requirements.txt: aiohttp: downgrade to version < 4 #81

Closed umgfoin closed 2 years ago

umgfoin commented 2 years ago

Workaround for dependency-side issue in aiohttp 4.0.0a1 with py3.8 | py3.9 aiohttp < 4.0.0.a1 seems to be unaffected.

aiohttp-4.0.0a1-py3.9-linux-x86_64.egg/aiohttp/client.py:977: RuntimeWarning: coroutine 'noop' was never awaited
  self._resp.release()

Signed-off-by: umgfoin umgfoin@users.noreply.github.com

decompil3d commented 2 years ago

Is this still an issue? If so, can you resolve conflicts and let me know?

umgfoin commented 2 years ago

Yes, aiohttp>=4.0.0a1 still has issues, but you added this PR's version-restrictions already in PR #85, so it's fine.