search

moloch-- / RootTheBox

A Game of Hackers (CTF Scoreboard & Game Manager)
http://root-the-box.com/
Apache License 2.0
935 stars 295 forks source link

refactoring code with List Comprehension #475

Closed idiomaticrefactoring closed 2 years ago

idiomaticrefactoring commented 2 years ago

refactoring code with List Comprehension which is more pythonic, concise and efficient; how do you think this change which has practical value？

eljeffeg commented 2 years ago

Yeah, not sure there is much value in rewriting working code if that's the only purpose of the change, but I'll accept the request. Certainly don't want to discourage those willing to contribute. 👍

eljeffeg commented 2 years ago

One area that is still pending that falls into this type of update is #414 We need to get RTB compatible with Python 3.9+, which will likely drop support for Python 2.7.