moloch-- / sliver-py

A Python gRPC Client Library for Sliver
GNU General Public License v3.0
62 stars 13 forks source link

Broken/Missing sliver 1.5 support #2

Closed cmprmsd closed 2 years ago

cmprmsd commented 2 years ago

It seems the client currently does not work with the current stage branch. The client does not expect a "token". This is the error with the "Event Example (Threads)" from your documentation.

python3 sliver-notificationbot.py
Traceback (most recent call last):
  File "/root/sliver-notificationbot.py", line 29, in <module>
    main()
  File "/root/sliver-notificationbot.py", line 15, in main
    config = SliverClientConfig.parse_config_file(DEFAULT_CONFIG)
  File "/usr/local/lib/python3.9/dist-packages/sliver/config.py", line 78, in parse_config_file
    return cls.parse_config(data)
  File "/usr/local/lib/python3.9/dist-packages/sliver/config.py", line 65, in parse_config
    return cls(**json.loads(data))
TypeError: __init__() got an unexpected keyword argument 'token'
moloch-- commented 2 years ago

Sliver v1.5 is not officially released yet, so no support yet. We'll update this library when we officially release v1.5

cmprmsd commented 2 years ago

Thanks for the heads up :) Looking forward to it!

moloch-- commented 2 years ago

Initial v1.5 support is in v0.0.15 and later, updated docs. I've removed the threaded client implementation as it was too much for me to maintain along with the asyncio versions, but you really should be using asyncio anways.

Not all v1.5 features are supported, but all the basics should be there.

cmprmsd commented 2 years ago

Thanks! I have to admit I quickly switched to the Go version in order to write the notification and conditional reaction bots. 🙂

Thanks for writing the wiki entry "write your own client"! 😁

Do you plan on offering some c2 training specifically on sliver? My company would certainly be interested.

moloch-- commented 2 years ago

Bishop Fox doesn't really sell training, so no plans to do that sorry! I've spoken to some folks that do sell training, and it sounds like Sliver may be incorporated into a few trainings given by 3rd parties though!

cmprmsd commented 2 years ago

Thanks for the heads up! I will keep a lookout for them :)