moloch-- / sliver-py

A Python gRPC Client Library for Sliver

GNU General Public License v3.0

62 stars 13 forks source link

start_wg_listener parameters #33

Open tabinfl opened 1 year ago

tabinfl commented 1 year ago

Describe the bug

start_wg_listener does not accept a host parameter, and requires tun_ip.

This is inconsistent with the other start listener functions, and does not reflect the actual requirements of the underlying gRPC call.

PR incoming.

tabinfl commented 1 year ago

36 also addresses this, an error is not raised if `tun_ip` is missing (in either wg listener or wg implant generation), but everything breaks at runtime if it is omitted.

Could do similar on implant generation, that's also done under the hood in the CLI but will break everything if omitted from a wg implant build. Happy to add that to the PR if you'd like.

moloch-- / sliver-py

start_wg_listener parameters #33

36 also addresses this, an error is not raised if tun_ip is missing (in either wg listener or wg implant generation), but everything breaks at runtime if it is omitted.

36 also addresses this, an error is not raised if `tun_ip` is missing (in either wg listener or wg implant generation), but everything breaks at runtime if it is omitted.