search

moloney / dcmstack

DICOM to Nifti conversion with meta data preservation
Other
72 stars 51 forks source link

Dicom Anonymizer #4

Open ssikka opened 11 years ago

ssikka commented 11 years ago

The code is barely documented and does not entirely conform to pep8.

I see this pull request as a chance to continue working on the documentation and code standards until everyone is satisfied.

moloney commented 11 years ago

Thanks for the hard work!

I haven't looked in too much detail, but I have a couple of questions:

1) Where do you see this integrating with dcmstack? It looks like you need to work with the original DICOM data set, not the extracted meta data. This would mean you would need to integrate this with a MetaExtractor object of some kind.

2) What about meta data from private elements? Are you always just going to discard all private elements?

moloney commented 11 years ago

Hi. It seems like you should be able to specify and ignore_rule to integrate this with the existing MetaExtractor object. Check out the examples "ignore_private" and "ignore_non_ascii_bytes" in the dcmstack.extract module.