search

moloney / dcmstack

DICOM to Nifti conversion with meta data preservation
Other
72 stars 51 forks source link

Changes required to use dcmstack with Python 3 #47

Closed ghisvail closed 5 years ago

ghisvail commented 7 years ago

This PR aggregates the list of changes I had to make to be able to call dcmstack within a Python 3 virtualenv.

mgxd commented 7 years ago

@moloney any chance you could take a look?

matthew-brett commented 7 years ago

New changes look fine to me.

moloney commented 7 years ago

Going through this now... thanks for all the work so far!

satra commented 6 years ago

@moloney - can this be merged?

r-b-g-b commented 6 years ago

I made a py3 compatibility branch myself before I noticed this PR. Two additional things I noticed:

  1. I also needed to change all xrange to range
  2. In dcmstack.axcodes2ornt, I needed to make zip('LPA', 'RAS') into list(zip('LPI', 'RAS')). That change is because python2 zip returns a list while python3 zip returns an iterable.

I'll try to pull this branch and add the following commits.

yarikoptic commented 5 years ago

eh, we need to get this one finalized... just ran into it again in https://github.com/nipy/heudiconv/pull/225 while thinking that we have it solved already

yarikoptic commented 5 years ago

FWIW -- looking into it atm