search

moloney / dcmstack

DICOM to Nifti conversion with meta data preservation
Other
72 stars 51 forks source link

Introduce and use properties (for shape, affine, header) to avoid nibabel deprecation warnings #64

Closed yarikoptic closed 4 years ago

yarikoptic commented 4 years ago

Introduced properties to ease RFing and also make this interface more inline with nibabel. More comments in the individual commits

codecov-io commented 4 years ago

Codecov Report

Merging #64 into master will increase coverage by 0.02%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #64      +/-   ##
=========================================
+ Coverage   80.88%   80.9%   +0.02%     
=========================================
  Files           8       8              
  Lines        2113    2116       +3     
=========================================
+ Hits         1709    1712       +3     
  Misses        404     404
Impacted Files Coverage Δ
src/dcmstack/info.py 93.1% <ø> (ø) :arrow_up:
src/dcmstack/nitool_cli.py 40.11% <0%> (ø) :arrow_up:
src/dcmstack/dcmmeta.py 86.61% <100%> (ø) :arrow_up:
src/dcmstack/dcmstack.py 88.56% <92.85%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2d1c72...7f84c2a. Read the comment docs.

moloney commented 4 years ago

Thanks for this! Sorry for being slow to merge.