search

molovo / browserWrapper

browserWrapper plugin, by @molovo
21 stars 3 forks source link

Windows8 #2

Closed japborst closed 11 years ago

japborst commented 11 years ago

The Windows style was quite Vista/W7 style and design-wise, I thought Win8 would be much better. Have created this just now. Buttons are fully transparent so any background colour can be used for Chrome to create a custom look.

@molovo: Should I create an Sandbox2 and push to that or which one is preferred?

Would love your thoughts on this.

Cheers!

Win8 style test

molovo commented 11 years ago

This is great! Push to dev might be a good idea, because that could be implemented straight away. Only thing I can see is that the tab needs to move a couple of pixels to the right as the rounded corner is currently hidden.

How does it look with the Firefox browser option?

molovo commented 11 years ago

Another thought, if you've done this by overriding all the windows styles then don't worry because this looks a lot better than the windows 7 version, but if they're still there we could keep both, have two options ('windows7' || 'windows8') and add some version detection to the plugin as well as browser/os

japborst commented 11 years ago

Will push to dev then :)

I thought of doing both indeed, but was a little too late with that. Will retrieve old CSS and merge mine with a .win8 class or alike.

I actually stripped down the version detection, so that can be added very easily as well. Will do so too. Which one to set as default? I'd say Win8.

Chrome rounded corner now (adjusted controls a little too): Chrome Win8

Firefox (also adjusted controls little, same as Chrome): Firefox Win8

molovo commented 11 years ago

I've got a lot of changes to merge in the CSS as well that are currently in the sandbox, so I'll try and get both done at the same time. It looks great! This will also save me the trouble of separating out the window buttons for some of the working iframe tweaks I've done :laughing:

On 4 May 2013 12:38, Jelmer Borst notifications@github.com wrote:

Will push to dev then :)

I thought of doing both indeed, but was a little too late with that. Will retrieve old CSS and merge mine with a .win8 class or alike.

I actually stripped down the version detection, so that can be added very easily as well. Will do so too. Which one to set as default? I'd say Win8.

Chrome rounded corner now (adjusted controls a little too): [image: Chrome Win8]https://a248.e.akamai.net/camo.github.com/13c6dc6ea14f574d4bb9be69d59ffd47e2f7b566/687474703a2f2f692e696d6775722e636f6d2f324f497752306d2e706e67

Firefox (also adjusted controls little, same as Chrome): [image: Firefox Win8]https://a248.e.akamai.net/camo.github.com/fd30f144c1951c871a3fb9ec49bdeccad15c331f/687474703a2f2f692e696d6775722e636f6d2f715237775353752e706e67

— Reply to this email directly or view it on GitHubhttps://github.com/molovo/browserWrapper/issues/2#issuecomment-17431846 .

japborst commented 11 years ago

That'd be awesome if you could merge/adjust for Win7. I will default to Win8 and add extra windows7 class for Win7 style.

molovo commented 11 years ago

Merged :)