reserved identifier violation

molpopgen / fwdpp

fwdpp is a C++ template library for implementing efficient forward-time population genetic simulations

http://fwdpp.readthedocs.io

GNU General Public License v3.0

27 stars 11 forks source link

reserved identifier violation #143

Closed elfring closed 6 years ago

elfring commented 6 years ago

I would like to point out that identifiers like “__DIPLOID_HH__” and “__FWDPP_SUGAR_GSL_TAGS_HPP__” do eventually not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

molpopgen commented 6 years ago

Closing b/c this is very low priority. The chances of a name clash are vanishingly small and there are other things to do with this project in the short term.

elfring commented 6 years ago

How do you think about to avoid that this software depends on undefined behaviour?