Initialization issues in marginal_tree - Githubissues

molpopgen / fwdpp

fwdpp is a C++ template library for implementing efficient forward-time population genetic simulations

http://fwdpp.readthedocs.io

GNU General Public License v3.0

27 stars 11 forks source link

Initialization issues in marginal_tree #218

Closed molpopgen closed 5 years ago

molpopgen commented 5 years ago

This is an issue with the current development branch.

In working through #217, I found problems with the constructors:

[x] samples lists should not be forwarded. they should be taken is as const references. Allowing moves isn't worth the complexity.
[x] The overload of marginal_tree::forward_input_samples for rvalue references is incorrect.
[x] Unit tests are needed for the case of sample groups in combination with preserved nodes. The current template type is the same for each sample list for this constructor, which cannot be correct.