molpopgen / fwdpp

fwdpp is a C++ template library for implementing efficient forward-time population genetic simulations
http://fwdpp.readthedocs.io
GNU General Public License v3.0
27 stars 11 forks source link

Generality of edge sorting #238

Closed molpopgen closed 4 years ago

molpopgen commented 4 years ago

The current implementation of ts::table_collection::sort_edges uses an offset value to minimize the amount of sorting to do. However, this approach is only correct when all individuals are replaced at each time step.

The best solution is probably to deprecate the current API and replace with a more general standalone function.

molpopgen commented 4 years ago

Note: we may render this moot by replacing sorting w/buffering.

molpopgen commented 4 years ago

This is largely moot due to #260