search

molpopgen / fwdpp

fwdpp is a C++ template library for implementing efficient forward-time population genetic simulations
http://fwdpp.readthedocs.io
GNU General Public License v3.0
27 stars 11 forks source link

GSLrng_t should have deleted copy constructor #50

Closed molpopgen closed 7 years ago

molpopgen commented 7 years ago

The current implementation allows copy-construction from a const reference. This can lead to side effects when objects are passed by value to functions.

I believe this design was due to some limitation w/Cython, but it really should be done away with. If anyone needs this type in Cython, redefine it as needed.

molpopgen commented 7 years ago

Closing: addressed in release 0.5.6