molpopgen / fwdpp

fwdpp is a C++ template library for implementing efficient forward-time population genetic simulations
http://fwdpp.readthedocs.io
GNU General Public License v3.0
27 stars 11 forks source link

update_mutations_n doesn't record fixation times of selected mutations #96

Closed molpopgen closed 6 years ago

molpopgen commented 6 years ago

This function should be refactored to behave like fwdpy11's. We need a lookup based on position for selected mutations, and only insert them into the fixations if the position doesn't already exist.

This issue does not affect simulation correctness. Rather, what happens is that fixation times of selected variants are lost when using this function.

(This does not affect fwdpy11, which uses custom functions for this.)