molpopgen / fwdpy11

Forward-time simulation in Python using fwdpp
https://molpopgen.github.io/fwdpy11
GNU General Public License v3.0
29 stars 6 forks source link

Timing of genetic value calculation vs fixation removal #1325

Open molpopgen opened 1 month ago

molpopgen commented 1 month ago

PR #1324 fixed an issue where fixations were not being "pruned" even when that option was True.

With that fix, though, we have the following behaviors:

Ultimately, these issues are all due to fwpdy11 being written to simulate traits and all the "pop gen" stuff is bolted on top.

It may be possible to move the order of when genetic values are calculated to AFTER fixation removal. Dealing with the simplification issue described above is harder -- we don't necessarily know the counts.

molpopgen commented 1 month ago

Quick experimentation changing the order of events results in most tests passing but the sweep tests seem to loop forever, implying that how we are monitoring for fixations is depending on the mutations being found in genomes.