search

molsonkiko / JsonToolsNppPlugin

A Notepad++ plugin providing tools for JSON like linting, querying, a tree view, and CSV conversion.
Apache License 2.0
93 stars 10 forks source link

Update CI_build.yml #18

Closed chcg closed 2 years ago

chcg commented 2 years ago
chcg commented 2 years ago

@molsonkiko See https://learn.microsoft.com/en-us/lifecycle/faq/dotnet-framework, do you think .Net 4 is really still necessary as support ended January 12, 2016? Maybe 4.5.2 is a better compromise than.

molsonkiko commented 2 years ago

Hi @chcg , I thought that maybe I could continue to use the old GitHub action and not have anything bad happen, and that's why I reverted back. I didn't realize that the GitHub Actions build would just outright fail if I didn't bump to .NET Framework 4.8.

Given that I don't seem to have much of a choice, I'm going to go back to the changes that were in your PR.

Question: in your opinion, is it better semantic versioning practice to bump the minor version of my plugin (i.e., go to 3.8.0), the major version (i.e., 4.0.0) or the bugfix version (i.e., 3.7.4) given that increasing the .NET framework version is a breaking change for some users?

chcg commented 2 years ago

4.0 as you did seems to be reasonable to me.