search

molsonkiko / JsonToolsNppPlugin

A Notepad++ plugin providing tools for JSON like linting, querying, a tree view, and CSV conversion.
Apache License 2.0
70 stars 9 forks source link

Repeated launch crashes due to plugin not actually being removed when prompted #46

Open tonyping opened 10 months ago

tonyping commented 10 months ago

OS: Windows 11 Insiders Canary [25931] Relevant background info:

I know this has been brought up before, but I'm getting the "Failed to load, JsonTools.dll is not compatible with the current version of Notepad++." with JsonToolsNppPlugin [5.6.0]. Possibly related to eef91b something or another.

But the reason I'm bringing up in a new issue, is that when responding to "Do you want to remove this plugin from the plugins directory to prevent this message from the next launch?" and clicking Yes on the dialog, JsonToolsNppPlugin continues on crashing because as it turns out; was unable to actually remove from the plugins folder, leading to an endless crash loop.

So is the inability to remove something related w/ the Npp Plugins Admin, or plugin itself? Because while I've seen several posts in the Npp forums regarding the CET flag causing crashing with other plugins, none of the posts seemed to mention any issues with removing.

molsonkiko commented 10 months ago

@tonyping Thanks for letting me know about this issue. Unfortunately I can't replicate this because I don't currently have access to a Windows 11 PC. Out of curiosity, have you had this problem before on Windows 10, or did it emerge on Windows 11?

That's very odd that JsonTools continued crashing after Plugins Admin tried to remove it. I'm not sure if I've had similar problems before with other problems; I think I may have. My general sense is that Plugins Admin is not very good at removing unusable plugins, and that the infinite loop issue you're describing is the fault of Plugins Admin.

Obviously it sucks that JsonTools has all these weird crash bugs, but I'm clueless as to their origin.

molsonkiko commented 10 months ago

Just installed Npp 8.5.6 on my own computer (Windows 10 Personal) and confirmed that (at least for my setup) this issue did not originate in 8.5.6

On Sun, Aug 20, 2023, 11:17 PM Tony Ping @.***> wrote:

OS: Windows 11 Insiders Canary [25931] Relevant background info:

  • JsonToolsNppPlugin [5.6.0]
  • Notepad++ [8.5.6]

I know this has been brought up before, but I'm getting the "Failed to load, JsonTools.dll is not compatible with the current version of Notepad++." with JsonToolsNppPlugin [5.6.0]. Possibly related to eef91b https://github.com/notepad-plus-plus/notepad-plus-plus/commit/eef91b02142efe9e4b2ea5c83d0470db61233d08 something or another.

But the reason I'm bringing up in a new issue, is that when responding to "Do you want to remove this plugin from the plugins directory to prevent this message from the next launch?" and clicking Yes on the dialog, JsonToolsNppPlugin continues on crashing because as it turns out; was unable to actually remove from the plugins folder, leading to an endless crash loop.

So is the inability to remove something related w/ the Npp Plugins Admin, or plugin itself? Because while I've seen several posts in the Npp forums regarding the CET flag causing crashing with other plugins, none of the posts seemed to mention any issues with removing.

— Reply to this email directly, view it on GitHub https://github.com/molsonkiko/JsonToolsNppPlugin/issues/46, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALAQAI5N54MKRJ7YERLFYQTXWL4ORANCNFSM6AAAAAA3X3425U . You are receiving this because you are subscribed to this thread.Message ID: @.***>

MasterCubo commented 10 months ago

Bumping this. I have the same issue, and I cannot even find JsonTools.dll on my hard drive. My guess is that the plugin manager did manage to delete the .dll file, but there's some residual cache that is causing it to crash.

molsonkiko commented 10 months ago

The Notepad++\plugins\JsonTools directory contains other files besides JsonTools.dll. Maybe deleting that entire folder would help?

Since I have no way to replicate this, I might guess that maybe it has something to do with the %AppData%/Roaming/Notepad++/plugins/config/JsonTools directory or lack thereof? JsonTools stores data there, and I have no particular idea why its presence or absence would cause NPP to crash *even after the plugin was uninstalled, but... :shrug: