molssi-seamm / molsystem

Molsystem provides a general class for handling molecular and periodic systems

GNU Lesser General Public License v3.0

3 stars 2 forks source link

Completed the initial implementation #2

Closed paulsaxe closed 4 years ago

paulsaxe commented 4 years ago

Added bonds and cell, and filled out the testing.

lgtm-com[bot] commented 4 years ago

This pull request introduces 5 alerts and fixes 3 when merging 68ebc2be82492443fef165630383f7cc1b0556ff into d3b1ec553407a98a61c1e1b570cd7fc92a3cf2c8 - view on LGTM.com

new alerts:

2 for Unused import
1 for __eq__ not overridden when adding attributes
1 for Suspicious unused loop iteration variable
1 for Unnecessary delete statement in function

fixed alerts:

2 for Unused import
1 for Implicit string concatenation in a list

codecov[bot] commented 4 years ago

Codecov Report

Merging #2 into master will increase coverage by 9.68%. The diff coverage is 100.00%.

lgtm-com[bot] commented 4 years ago

This pull request introduces 2 alerts and fixes 3 when merging c93df71d931dc3cdd220e070d3600d2ef3aa9cf6 into d3b1ec553407a98a61c1e1b570cd7fc92a3cf2c8 - view on LGTM.com

new alerts:

1 for __eq__ not overridden when adding attributes
1 for Suspicious unused loop iteration variable

fixed alerts:

2 for Unused import
1 for Implicit string concatenation in a list