molssi-seamm / molsystem

Molsystem provides a general class for handling molecular and periodic systems

GNU Lesser General Public License v3.0

3 stars 2 forks source link

A quite substantial rewrite mainly of the templates & subsets. #20

Closed seamm closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (fb6f916) into main (e5dd66d) will decrease coverage by 9.49%. The diff coverage is 71.05%.

lgtm-com[bot] commented 3 years ago

This pull request introduces 9 alerts and fixes 7 when merging c3aaea80496b251ee49355c82a07b7b1333f2f12 into e5dd66d844439cac291e00d02d30231b5ec4eff2 - view on LGTM.com

new alerts:

4 for __eq__ not overridden when adding attributes
2 for Unused import
1 for Comparison using is when operands support __eq__
1 for Missing call to __init__ during object initialization
1 for Variable defined multiple times

fixed alerts:

5 for __eq__ not overridden when adding attributes
2 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request introduces 2 alerts and fixes 7 when merging c4468bd2e948db6096927d45a4cc75274c574d12 into e5dd66d844439cac291e00d02d30231b5ec4eff2 - view on LGTM.com

new alerts:

1 for Comparison using is when operands support __eq__
1 for Variable defined multiple times

fixed alerts:

5 for __eq__ not overridden when adding attributes
2 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request fixes 7 alerts when merging fb6f916c1824a721ad2d43d41ed315bd33f48719 into e5dd66d844439cac291e00d02d30231b5ec4eff2 - view on LGTM.com

fixed alerts:

5 for __eq__ not overridden when adding attributes
2 for Unused local variable