DOF shader

[corredD]

DOF planar effect

[dsehnal]

Cool

[arose]

Hi, two quick comments

• It should use the output from the anti-alias pass as input when enabled.
• I struggle to find working values for "In Focus" and "PPM". Could you change it so it is expressed in percentage values of the (visible) scene bounding sphere radius? At least as an option.

[corredD]

I use the scene bounding sphere so its easier to find the proper area to be in focus. It will be the area at distance inFocus from the scene center. PPM is the size of the area. I am trying to use the anti-alias pass, but when I use this.antialiasing.target.texture, the texture is emtpy ? How should the target be defined ? const input = antialiasingEnabled ? this.antialiasing.target.texture : (postprocessingEnabled ? this.postprocessing.target.texture : this.drawTarget.texture); Lastly I would like to be able to pass a toggle option, where the area in focus could be either the scene center or the current selection or mark. How could I retrieve this information of current loci/mark position from the render pass ?

[arose]

I am trying to use the anti-alias pass, but when I use this.antialiasing.target.texture, the texture is emtpy ? How should the target be defined ? const input = antialiasingEnabled ? this.antialiasing.target.texture : (postprocessingEnabled ? this.postprocessing.target.texture : this.drawTarget.texture);

will have to have a look

Lastly I would like to be able to pass a toggle option, where the area in focus could be either the scene center or the current selection or mark. How could I retrieve this information of current loci/mark position from the render pass ?

I think that is best done via a behavior that listens to selection changes and sets the dof params accordingly

[arose]

One thing I notices (specifically with 1TQN or another small example) is that there is blur even in the middle of the focus region.

[corredD]

It should be easier now to control the position of the effect, it use either the center of the visible scene or the camera current target position. In planar mode, the blur effect is applied to the plane at distance inFocus of the center z distance with a width of PPM. In spherical mode, the blur effect is applied outside a sphere centered at center and of radius PPM.

now just need to figure out how to pass the correct inputTarget : const input = antialiasingEnabled ? this.antialiasing.target.texture : (postprocessingEnabled ?

[arose]

Very nice addition with he camera target. Should it be the default?

Should PPM be exponential to make it more use-friendly in UI? Or maybe we should add ParameterControl opion for that, @dsehnal?

Parts that are in focus get some blurry halo, see below. Can the halo be avoided?

[dsehnal]

Should PPM be exponential to make it more use-friendly in UI? Or maybe we should add ParameterControl opion for that, @dsehnal?

Can you be a little more specific please?

[arose]

Should PPM be exponential to make it more use-friendly in UI? Or maybe we should add ParameterControl opion for that, @dsehnal?

Can you be a little more specific please?

exponential step-size, so you have finer control at smaller values