molstar / molstar

A comprehensive macromolecular library
https://molstar.org
MIT License
646 stars 147 forks source link

Bloom effect discussion #1115

Open arose opened 5 months ago

arose commented 5 months ago

I just want to report a few differences i noticed on this comparison

I'm wondering if it is possible to enhance the effect of blooming on opaque background to uniform it to the tranpsarent backgorund? Also is it possible to apply a better bloom smoothing effect that sometimes could be useful? (maybe only when exporting snapshots if this would lead to performances issues)

test

Originally posted by @giagitom in https://github.com/molstar/molstar/pull/1083#pullrequestreview-2039564769

dsehnal commented 4 months ago

If you do a canvas with transparent background and have a black background div underneath it, are the artifacts also visible like in your GIMP example?

giagitom commented 4 months ago

If you do a canvas with transparent background and have a black background div underneath it, are the artifacts also visible like in your GIMP example?

@dsehnal In this case I'm seeing it without artifacts.

image

I further checked in GIMP and have found that I need to change color space mode from linear to perceptual in order to get the correct result, if I correctly recall I had the same problem with common transparent objects. My bad, I should have remembered this. I'm not sure why GIMP is not using the correct color space by default though. The default ubuntu image viewer opens the image correctly.