molstar / molstar

A comprehensive macromolecular library

https://molstar.org

MIT License

596 stars 139 forks source link

Add round caps on tubular alpha helices #1120

Open giagitom opened 3 weeks ago

giagitom commented 3 weeks ago

Description

This PR adds round caps option on tubular helices

Known issues

Normals at the extremities should be smoothed in some way.

Also not sure why, if caps are near gaps something goes wrong on the cap shape

Actions

[x] Added description of changes to the [Unreleased] section of CHANGELOG.md
[x] Updated headers of modified files
[ ] Added my name to package.json's contributors
[ ] (Optional but encouraged) Improved documentation in docs

giagitom commented 2 weeks ago

@arose in last commit i tried to smooth normals. Now vertices are smoothed but colors are wrong. Could you check on the approach I am using? I'm not sure this is the correct way of doing this.

giagitom commented 2 weeks ago

Also not sure why, if caps are near gaps something goes wrong on the cap shape

Should be fixed now with d2192d6 (tested with PDB ID 2XUT)