search

molstar / molstar

A comprehensive macromolecular library
https://molstar.org
MIT License
596 stars 139 forks source link

Possible way to clean transparent cylinders while on solidInterior mode. #1124

Open giagitom opened 2 weeks ago

giagitom commented 2 weeks ago

@arose, what do you think about the following patch to clean unwanted caps on transparent cylinders using solidInterior mode? cylinders-solidInterior+transparency.diff.txt

Before

image

After

image

dsehnal commented 2 weeks ago

I like it.

dsehnal commented 2 weeks ago

I wonder if if we could also propagate a top/bottom-sphere-radius param and discard the pixels that intersect with the sphere.

giagitom commented 1 week ago

I wonder if if we could also propagate a top/bottom-sphere-radius param and discard the pixels that intersect with the sphere.

@dsehnal I think I already discussed this with @arose some time ago https://github.com/molstar/molstar/pull/665#issuecomment-1352640437